Control: tags -1 -confirmed Control: tags -1 +moreinfo Sebiastien,
Preamble... Thank you for taking the time to prepare this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build: * pbuilder [1]: Good * sbuild [2]: Good 2. Lintian [3]: Issue Running lintian... N: W: openmohaa source: inconsistent-appstream-metadata-license misc/linux/org.openmoh.openmohaa.metainfo.xml (fsfap != gpl-2+) [debian/copyright] N: N: The specified AppStream metadata file specifies a metadata_license field N: but this does not match its entry (possibly via the Files: * stanza) in N: debian/copyright. N: N: Please refer to https://wiki.debian.org/AppStream/Guidelines, N: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/, and N: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-metadata_license N: for details. N: N: Visibility: warning N: Show-Always: no N: Check: debian/copyright/dep5 N: N: I: openmohaa source: invalid-dep3-format-patch-no-origin [debian/patches/format_security.patch] N: N: According to the DEP-3, this patch's headers should contain the Origin N: field. N: N: Please refer to https://dep-team.pages.debian.net/deps/dep3/ for details. N: N: Visibility: info N: Show-Always: no N: Check: debian/patches/dep3 N: N: I: openmohaa source: invalid-dep3-format-patch-no-origin [debian/patches/remove_archstring.patch] N: I: openmohaa source: invalid-dep3-format-patch-no-origin [debian/patches/spelling_error.patch] N: I: openmohaa source: invalid-dep3-format-patch-no-origin [debian/patches/use_system_libs.patch] N: N: Debian specific wrapper - not for upstream O: openmohaa source: maintainer-manual-page [debian/mohaa.6] N: N: The maintainer keeps a manual page in ./debian. Please forward the manual N: page upstream and ask them to include in their version control system, and N: in their next release. N: N: If the manual page was already forwarded or rejected, or the upstream is N: gone, please override the tag and annotate it with a suitable comment. N: N: Please refer to social contract item 2, Coordination with upstream N: developers (Section 3.1.4) in the Debian Developer's Reference, and N: Changes to the upstream sources (Section 4.3) in the Debian Policy Manual N: for details. N: N: Visibility: pedantic N: Show-Always: no N: Check: debian/manual-pages N: Renamed from: maintainer-manpage N: E: Lintian run failed (runtime error) 3. Licenses [4]: Issue, possible false positives philwyett@ks-tarkin:~/Development/builder/debian/openmohaa-0.80.0+dfsg$ lrc en: Versions: recon 3.2 check 3.3.9-1 Parsing Source Tree .... Reading d/copyright .... Running licensecheck .... d/copyright | licensecheck public-domain | GPL-2 and/or public-domain code/autoupdater/autoupdater.c RSA-MD5 | NTP code/gamespy/md5c.c RSA-MD5 | NTP code/gamespy/md5.h GPL-2+ | Zlib code/qcommon/unzip.h public-domain | GPL-2 and/or public-domain code/sys/sys_autoupdater.c RSA-MD4 | NTP code/tools/ommap/common/md4.c 4. Watch file [uscan --force-download]: Good 5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good 6. Reproducible builds [5]: Good 7. Install [No previous installs]: Good 8. Upgrade [Over previous installs if any]: N/A ummary... I believe openmohaa is not yet ready for sponsorship at this time. Could the contributor rectify one of more of the raised issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' tag on the Request For Sponsorship (RFS) bug report. Regards Phil [1] pbuilder: * Command: sudo pbuilder build <PACKAGE>.dsc * Document: https://wiki.ubuntu.com/PbuilderHowto. * Document: https://wiki.debian.org/PbuilderTricks [2] sbuild: * Command: sbuild <PACKAGE>.dsc * Document: https://wiki.debian.org/sbuild [3] lintian: * Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different results, so be thorough. * Document: https://wiki.debian.org/Lintian [4] lrc: * Command: lrc * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon [5] reprotest * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto- build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004 * Document: https://wiki.debian.org/ReproducibleBuilds/ * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- Donations... Buy Me A Coffee: https://buymeacoffee.com/kathenasorg Liberapay: https://liberapay.com/kathenas -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Matrix: #kathenas:matrix.org Website: https://kathenas.org Wiki: https://wiki.kathenas.org Instagram: https://instagram.com/kathenasorg Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
