On 11/16/24 18:15, Santiago Vila wrote:
tags 1069097 patch
thanks
If I'm not mistaken, the problem happens because the "compress" call
in the postinst fails.
Correct.
At this moment, we still don't know if this is a bug in the compress
utility (from django), for acting wrongly on a correct input, or maybe
the input itself is wrong to begin with.
From the error, I can see:
CommandError: An error occurred during rendering serial_console.html:
Syntax error: Found 'inline-blo' but expected one of ADD,
ALPHA_FUNCTION, BANG_IMPORTANT, BAREWORD, COLOR, DOUBLE_QUOTE, FNCT,
IF_FUNCTION, INTERP_START, LITERAL_FUNCTION, LPAR, NOT, NUM, SIGN,
SINGLE_QUOTE, URL_FUNCTION, VAR
So, trying to render the Django template serial_console.html, compress
fails, when it see 'inline-blo'. IMO, it must be:
display:inline-block;
from the file
openstack_dashboard/static/dashboard/scss/serial_console.scss. At first
glance, I didn't get it, but looking further, when doing a grep, it
appears that the "display:inline-block" in this file is the only one I
can see in the whole horizon source code that doesn't have a space after
the semi-column. This may be it!
At the current moment, what I've done was this commit:
https://salsa.debian.org/openstack-team/services/horizon/-/commit/5798795e33880c0225aaf298a9a82f4aecfda14d
This is a workaround which I would prefer to avoid: by deleting the
serial_console.html Django template, I'm breaking one of the Horizon
functionality. One that most people wont use (everyone uses VNC), though
I'd prefer to not do that.
So, I was wondering, if you know how to reproduce (which so far I
haven't been able to on my laptop or otherwise), could you try the trick
of adding a space in "display:inline-block" in serial_console.scss and
see if that's enough to fix it?
In either case, we want the build to always succeed. Given that this
compress thing
is not an absolutely essential feature, I propose that we make the failure
to be non-fatal for the time being, as in the attached patch.
I don't agree. Having pre-compressed artifacts is super important,
otherwise it takes forever to browse with Horizon. I don't want this to
be broken or disabled.
In any case, thanks for all the research, and time you spent on this
package already. Hopefully, what I've discovered will definitively fix it.
Cheers,
Thomas Goirand (zigo)
