Bug#1075783: RFS: mintstick/1.6.2-1 [ITA] -- USB stick formatter and ISO image writer

[肖盛文]

Hi Phil,

On Fri, 05 Jul 2024 10:36:02 +0100 Phil Wyett <philip.wy...@kathenas.org> wrote:

Hi Xiao,

Preamble...

Thanks for taking time to create this package and your contribution to Debian.

The below review is for assistance. It is offered to help submitters of
packages to Debian mentors improve their packages prior to possible
sponsorship into Debian. There is no obligation on behalf of the subitter to
make any alterations based upon information provided in the review.

Review...

1. Build: Good

2. Lintian: Issue

I: mintstick source: debian-watch-uses-insecure-uri http://packages.linuxmint.com/pool/main/m/mintstick/ [debian/watch:4] N: N: The watch file uses an unencrypted transport protocol for the URI such as

N:   http:// or ftp://. It is recommended to use a secure transport such as
N:   HTTPS for anonymous read-only access.

N:   contact them and ask them to consider adding one.

N:   Show-Always: no
N:   Check: debian/watch
N:

Would be nice to get the release archive from the secure github project.

N: N: Upstream may already provide a HTTPS variant of the URI. If not, please N: N: Visibility: info

1. linuxmint apt repo has not https

2. Please see https://github.com/linuxmint/mintstick/tags, it's tags version number is not suitable used in debian/watch.

> Additional....


Perhaps, I'm not sure too.



python3-unidecode is also exist in Ubuntu. This bug is fixed in 1.6.1-1.

mintstick (1.6.1-1) unstable; urgency=medium

  * QA upload.
  * New upstream release.
  * debian/control: Add missing dependency python3-unidecode.

 -- Boyuan Yang <by...@debian.org>  Tue, 18 Jun 2024 15:22:02 -0400



--
肖盛文 xiao sheng wen

> A. Why there is 'TERM=xterm' in scripts. One for - is it needed upstream etc. etc.? :-) > B. Not related, but would be nice to address. 'mintstick' is currently broken in Ubuntu 24.04 (maybe other releases also - not tested) due to not installing dep 'python3-unidecode'. https://www.atzlinux.com 《铜豌豆 Linux》基于 Debian 的 Linux 中文 桌面 操作系统 Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com

Debian salsa: https://salsa.debian.org/atzlinux-guest
GnuPG Public Key: 0x00186602339240CB

OpenPGP_signature.asc
Description: OpenPGP digital signature