Hi Xiao, Preamble...
Thanks for taking time to create this package and your contribution to Debian. The below review is for assistance. It is offered to help submitters of packages to Debian mentors improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the subitter to make any alterations based upon information provided in the review. Review... 1. Build: Good 2. Lintian: Issue I: mintstick source: debian-watch-uses-insecure-uri http://packages.linuxmint.com/pool/main/m/mintstick/ [debian/watch:4] N: N: The watch file uses an unencrypted transport protocol for the URI such as N: http:// or ftp://. It is recommended to use a secure transport such as N: HTTPS for anonymous read-only access. N: N: Upstream may already provide a HTTPS variant of the URI. If not, please N: contact them and ask them to consider adding one. N: N: Visibility: info N: Show-Always: no N: Check: debian/watch N: Would be nice to get the release archive from the secure github project. I: mintstick: desktop-entry-lacks-keywords-entry [usr/share/applications/mintstick-format- kde.desktop] N: N: This .desktop file is either missing a Keywords entry, or it does not N: contain keywords above and beyond those already present in the Name or N: GenericName entries. N: N: The Keywords field is intended to show keywords relevant for a .desktop N: file. N: N: Desktop files are organized in key-value pairs and are similar to INI N: files. N: N: The desktop-file-validate tool in the desktop-file-utils package may be N: useful when checking the syntax of desktop entries. N: N: Please refer to N: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html, N: Bug#693918, and N: https://wiki.gnome.org/Initiatives/GnomeGoals/DesktopFileKeywords for N: details. N: N: Visibility: info N: Show-Always: no N: Check: menu-format N: N: I: mintstick: desktop-entry-lacks-keywords-entry [usr/share/applications/mintstick-format.desktop] N: I: mintstick: desktop-entry-lacks-keywords-entry [usr/share/applications/mintstick-kde.desktop] N: I: mintstick: desktop-entry-lacks-keywords-entry [usr/share/applications/mintstick.desktop] Can be requested upstream. They may wish to add them or not. 3. Licenses: Good 4. Build Twice (sudo pbuilder build --twice <package>.dsc): Good 5. Reproducible builds (reporotest)[1]: Good 6. Install (No previous installs): Good 7. Upgrade (Over previous installs if any): Good Additional.... A. Why there is 'TERM=xterm' in scripts. One for - is it needed upstream etc. etc.? :-) B. Not related, but would be nice to address. 'mintstick' is currently broken in Ubuntu 24.04 (maybe other releases also - not tested) due to not installing dep 'python3-unidecode'. Summary... I believe mintstick is ready for sponsorship/upload. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready. I hope the new maintainer will look at the issues and work with upstream to improve the package for end users over future uploads. [1] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method Regards Phil -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
signature.asc
Description: This is a digitally signed message part
