Hi Mathias, Mathias Gibbens <gib...@debian.org> writes:
> Hi Free and Laszlo, > > On Sat, 2023-10-14 at 10:31 +0100, Free Ekanayaka wrote: >> As a consequence, I've renamed the libraft2 binary package to >> libraft0. Note that libraft0 already exists in bullseye, but there's >> nothing depending on it, so even in the weird case where somebody >> downloads libraft0 from sid and installs it in bullseye, nothing >> should break. > > Free, have you tested the upgrade path from a bullseye system with > libraft0 installed incrementally through to sid? Even though it's > probably a remote edge case, we should make sure the upgrade path works > smoothly. (Both with just libraft0 installed directly, as well as > indirectly by something like dqlite.) I've tried the upgrade path from bookworm to sid, both with just libraft2 installed directly as well as indirectly via dqlite. For bullseye there's only the case of libraft0 installed directly, since there's no dqlite in bullseye. I'll test the incremental upgrade to bookworm and then to sid and let you know. > I've looked over the current packaging in salsa, and pushed a few > commits cleaning up the packaging a bit. Thanks! > I have two remaining comments: > > First, it looks like you've intending to introduce a libraft-tools > package, but it is currently empty -- do you mean to install something > for that binary package? Also, its short description is a copy of > libraft0's. Yeah that stanza in d/control is pre-existing, I assume Laszlo intended to ship the raft-benchmark binary in it, but didn't for some reason (perhaps compilation issue). See also this snippet in d/rules: #override_dh_auto_configure: # dh_auto_configure -- --enable-benchmark I'll try to give it a stab and ship the raft-benchmark binary too. > Second, there's an existing patch in the packaging -- could that be > included in the upstream code so we can eliminate the Debian-specific > bit? Ah yeah, that patch is not relevant anymore in cowsql/raft, since that code isn't there anymore. I'll just drop it from the packaging branch. Free
