On 12/09/2014 08:10 PM, Adam D. Barratt wrote:
> Control: tags -1 + confirmed moreinfo
>
> Looking at your diff:
>
> -Build-Depends: debhelper (>= 9), dh-autoreconf, libglib2.0-dev (>= 2.32.0), 
> libgtk-3-dev (>= 3.10.0), libperl-dev (>= 5.10.0), gettext (>= 0.14.5), 
> libgtkspell3-3-dev, libgnutls28-dev, zlib1g-dev
> +Build-Depends: debhelper (>= 9), dh-autoreconf, quilt, libglib2.0-dev (>= 
> 2.32.0), libgtk-3-dev (>= 3.10.0), libperl-dev (>= 5.10.0), gettext (>= 
> 0.14.5), libgtkspell3-3-dev, libgnutls28-dev, zlib1g-dev
> [...]
> -       dh $@ --with autoreconf --parallel
> +       dh $@ --with autoreconf --with quilt --parallel
>
> That change is on the list of things /not/ to do on
> https://release.debian.org/jessie/freeze_policy.html#getting-unblocks
>
> It's also entirely unnecessary, as the package already declares itself
> to use source format "3.0 (quilt)". Please revert the above changes and
> go ahead, removing the "moreinfo" tag once the package is in unstable.

Thanks for the hints, I've prepared a new package without those changes.
I'm attaching the new debdiff, and I'll remove the moreinfo tag once it
gets in unstable.


-- 
Some assembly required.

Eduardo M KALINOWSKI
edua...@kalinowski.com.br

diff -Nru kildclient-3.0.0/debian/changelog kildclient-3.0.0/debian/changelog
--- kildclient-3.0.0/debian/changelog	2014-09-06 07:48:34.000000000 -0300
+++ kildclient-3.0.0/debian/changelog	2014-12-09 20:20:51.000000000 -0200
@@ -1,3 +1,10 @@
+kildclient (3.0.0-2) unstable; urgency=medium
+
+  * Added work-around to enable scroll-to-end feature to work with
+    GTK+ >= 3.13. Closes: #772096
+
+ -- Eduardo M Kalinowski <edua...@kalinowski.com.br>  Mon, 08 Dec 2014 20:13:37 -0200
+
 kildclient (3.0.0-1) unstable; urgency=low
 
   * New upstream version: 3.0.0.
diff -Nru kildclient-3.0.0/debian/patches/fix-scroll-to-end.patch kildclient-3.0.0/debian/patches/fix-scroll-to-end.patch
--- kildclient-3.0.0/debian/patches/fix-scroll-to-end.patch	1969-12-31 21:00:00.000000000 -0300
+++ kildclient-3.0.0/debian/patches/fix-scroll-to-end.patch	2014-12-09 20:20:51.000000000 -0200
@@ -0,0 +1,24 @@
+Description: Enable scroll-to-end with GTK+ >= 3.13
+ Starting with GTK+ 3.13, animation support in GtkAdjustment has made
+ the scroll-to-end function when new text is received to stop working.
+ This patch disables animation in the affected widget so that the
+ scroll-to-end functionality works again.
+Author: Eduardo M Kalinowski <edua...@kalinowski.com.br>
+Origin: upstream, http://sourceforge.net/p/kildclient/git/ci/6458ef77880967208c6481413ce631716193f8bf
+Bug-Debian: http://bugs.debian.org/772096
+Last-Update: 2014-12-08
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/src/worldgui.c
++++ b/src/worldgui.c
+@@ -153,6 +153,10 @@
+   gtk_scrolled_window_set_policy(gui->scrolled_win,
+                                  GTK_POLICY_AUTOMATIC,
+                                  GTK_POLICY_ALWAYS);
++  /* With the default (on), scroll-to-end does not work with GTK+ >= 3.13 */
++  g_object_set(gtk_widget_get_settings(GTK_WIDGET(gui->scrolled_win)),
++               "gtk-enable-animations", FALSE,
++               NULL);
+ 
+   gui->txtView = GTK_TEXT_VIEW(gtk_text_view_new());
+   gtk_text_view_set_editable(gui->txtView, FALSE);
diff -Nru kildclient-3.0.0/debian/patches/series kildclient-3.0.0/debian/patches/series
--- kildclient-3.0.0/debian/patches/series	1969-12-31 21:00:00.000000000 -0300
+++ kildclient-3.0.0/debian/patches/series	2014-12-09 20:20:51.000000000 -0200
@@ -0,0 +1 @@
+fix-scroll-to-end.patch

Reply via email to