Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock

KildClient is a client to connect to MUDs, or text-based multi-user role-
playing games. It's basically a telnet client with features specific to MUDs.

Bug #772096 has been filed against it: due to some behavior changes in GTK+ >=
3.13, KildClient does not scroll automatically to the bottom when text is
received. This makes using the program really painful to use (if not useless),
think of using a terminal emulator that does not automatically displays more
output, requiring the user to scroll after each sent command.

I've been able to find a very simple workaround that restores the desired
behavior, and made a debian package incorporating the changes. The debdiff is
attached.

I'm not a DD, so if approved, I'll have to ask on -mentors for a sponsor. The
package is on mentors.debian.net: https://mentors.debian.net/package/kildclient


unblock kildclient/3.0.0-2

-- System Information:
Debian Release: 8.0
  APT prefers testing
  APT policy: (900, 'testing'), (50, 'unstable'), (40, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
diff -Nru kildclient-3.0.0/debian/changelog kildclient-3.0.0/debian/changelog
--- kildclient-3.0.0/debian/changelog	2014-09-06 07:48:34.000000000 -0300
+++ kildclient-3.0.0/debian/changelog	2014-12-09 19:03:40.000000000 -0200
@@ -1,3 +1,10 @@
+kildclient (3.0.0-2) unstable; urgency=medium
+
+  * Added work-around to enable scroll-to-end feature to work with
+    GTK+ >= 3.13. Closes: #772096
+
+ -- Eduardo M Kalinowski <edua...@kalinowski.com.br>  Mon, 08 Dec 2014 20:13:37 -0200
+
 kildclient (3.0.0-1) unstable; urgency=low
 
   * New upstream version: 3.0.0.
diff -Nru kildclient-3.0.0/debian/control kildclient-3.0.0/debian/control
--- kildclient-3.0.0/debian/control	2014-09-06 07:48:34.000000000 -0300
+++ kildclient-3.0.0/debian/control	2014-12-09 19:03:40.000000000 -0200
@@ -2,7 +2,7 @@
 Section: games
 Priority: optional
 Maintainer: Eduardo M Kalinowski <edua...@kalinowski.com.br>
-Build-Depends: debhelper (>= 9), dh-autoreconf, libglib2.0-dev (>= 2.32.0), libgtk-3-dev (>= 3.10.0), libperl-dev (>= 5.10.0), gettext (>= 0.14.5), libgtkspell3-3-dev, libgnutls28-dev, zlib1g-dev
+Build-Depends: debhelper (>= 9), dh-autoreconf, quilt, libglib2.0-dev (>= 2.32.0), libgtk-3-dev (>= 3.10.0), libperl-dev (>= 5.10.0), gettext (>= 0.14.5), libgtkspell3-3-dev, libgnutls28-dev, zlib1g-dev
 Standards-Version: 3.9.5
 Homepage: http://www.kildclient.org
 Vcs-Browser: http://sourceforge.net/p/kildclient/git/ci/master/tree/debian/
diff -Nru kildclient-3.0.0/debian/patches/fix-scroll-to-end.patch kildclient-3.0.0/debian/patches/fix-scroll-to-end.patch
--- kildclient-3.0.0/debian/patches/fix-scroll-to-end.patch	1969-12-31 21:00:00.000000000 -0300
+++ kildclient-3.0.0/debian/patches/fix-scroll-to-end.patch	2014-12-09 19:03:40.000000000 -0200
@@ -0,0 +1,24 @@
+Description: Enable scroll-to-end with GTK+ >= 3.13
+ Starting with GTK+ 3.13, animation support in GtkAdjustment has made
+ the scroll-to-end function when new text is received to stop working.
+ This patch disables animation in the affected widget so that the
+ scroll-to-end functionality works again.
+Author: Eduardo M Kalinowski <edua...@kalinowski.com.br>
+Origin: upstream, http://sourceforge.net/p/kildclient/git/ci/6458ef77880967208c6481413ce631716193f8bf
+Bug-Debian: http://bugs.debian.org/772096
+Last-Update: 2014-12-08
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/src/worldgui.c
++++ b/src/worldgui.c
+@@ -153,6 +153,10 @@
+   gtk_scrolled_window_set_policy(gui->scrolled_win,
+                                  GTK_POLICY_AUTOMATIC,
+                                  GTK_POLICY_ALWAYS);
++  /* With the default (on), scroll-to-end does not work with GTK+ >= 3.13 */
++  g_object_set(gtk_widget_get_settings(GTK_WIDGET(gui->scrolled_win)),
++               "gtk-enable-animations", FALSE,
++               NULL);
+ 
+   gui->txtView = GTK_TEXT_VIEW(gtk_text_view_new());
+   gtk_text_view_set_editable(gui->txtView, FALSE);
diff -Nru kildclient-3.0.0/debian/patches/series kildclient-3.0.0/debian/patches/series
--- kildclient-3.0.0/debian/patches/series	1969-12-31 21:00:00.000000000 -0300
+++ kildclient-3.0.0/debian/patches/series	2014-12-09 19:03:40.000000000 -0200
@@ -0,0 +1 @@
+fix-scroll-to-end.patch
diff -Nru kildclient-3.0.0/debian/rules kildclient-3.0.0/debian/rules
--- kildclient-3.0.0/debian/rules	2014-09-06 07:48:34.000000000 -0300
+++ kildclient-3.0.0/debian/rules	2014-12-09 19:03:40.000000000 -0200
@@ -9,7 +9,7 @@
 
 
 %:
-	dh $@ --with autoreconf --parallel
+	dh $@ --with autoreconf --with quilt --parallel
 
 override_dh_auto_install-indep:
 	$(MAKE) -C doc DESTDIR=$(CURDIR)/debian/kildclient-doc install

Reply via email to