On Wed, 03 Dec 2014 00:43:37 +0100, Jan wrote: > > This looks better, doesn't it :) > > PID USER PRI NI VIRT RES SHR S CPU% MEM% TIME+ Command > > 31723 gregoa 20 0 556M 60748 19616 S 0.0 1.5 12:30.11 ./dianara > > 5789 gregoa 20 0 1752M 628M 44124 S 4.8 16.4 2h13:06 iceweasel > It looks a lot better! > Does this difference apply to similar usage, with same number of posts > per page, same update interval and running for a similar amount of time? > Even so, memory usage depends greatly on what's in the posts, of course.
I guess that my usage and settings should be roughly the same and ... > But you also say that now the memory usage stays constant, so it sounds > very promising =) ... that's indeed the most pleasant experience. > > With the help of a friend and qtcreator's nice valgrind integration I > > created a patch which adds parents to some objects (so that they are > > auto-reaped) or manually deletes them. > I find it a little strange that it really fixes things, mainly because, > from what I've seen by giving it a quick look, the fixes are mostly > specifying the parents of several objects, and manually deleting others. That's correct. > The reason those objects (at least, most of them) don't have a parent > set, is because they're re-parented when they're managed by a QLayout. > There's of course, the possibility of Qt bugs and that not being handled > correctly. Yeah, I'm a bit confused as well. My current understanding is that this re-parenting only works for elements which are added to others with addWidget() or addItem() and friends, but not for others which just are created and then linger around. And that's also why I added parents (more or less) only to this kind of elements and not to all. > The same applies to the manual deletion of some widgets in > Comment(); those are supposed to be properly deleted automatically when > the parent Comment() object is destroyed. Right, that's a mystery to me as well. Those labels are all added to layouts after all. But valgrind complained about not deleted labels. Adding "this" led to layout changes (?!), that's why I tried to delete them manually in the destructor. > There are also a few objects which will live as long as the program does, > so those are not really a concern either way (tray icon, menus, qoauth > handler...). Ok, it's quite possible that i was a bit over-enthusiastic :) > > I'll investigate, thanks again! Thanks! Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `-
signature.asc
Description: Digital Signature
