Package: downtimed
Version: 0.6-3
Severity: serious
User: pkg-systemd-maintain...@lists.alioth.debian.org
Usertags: systemd-units

The systemd service file shipped with downtimed has several issues:
- it starts downtimed with -D, which disables database updates. Surely
  that's not what's expected. (Hence severity serious.)
- the daemon forks, but the service isn't configured properly for that
  and as a result the unit remains in state "inactive (dead)".
  Since there's no option to disable forking, it should use Type=forking
  and let systemd guess the right PID (which it does).
- the reload action, which was present in the sysv init script, has not
  been reimplemented.
- the description contains a typo, and doesn't really describe the
  service anyway.
- KillMode=process is not necessary, the default would be fine.
- After=network.target is not necessary.

I guess that this service file was adapted from ssh.service, which is
where the -D, KillMode and After come from... but as-is, it's broken.

Here's a better version:

| [Unit]
| Description=Downtime record keeper
| 
| [Service]
| EnvironmentFile=-/etc/default/downtimed
| ExecStart=/usr/sbin/downtimed $DOWNTIMED_OPTS
| ExecReload=/bin/kill -HUP $MAINPID
| Type=forking
| Restart=on-failure
| 
| [Install]
| WantedBy=multi-user.target

Thanks,

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (650, 'testing'), (600, 'unstable'), (550, 'experimental'), (550, 
'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-rc7-ore (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages downtimed depends on:
ii  init-system-helpers  1.19
ii  libc6                2.19-7
ii  lsb-base             4.1+Debian13

downtimed recommends no packages.

downtimed suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to