On Fri, Jul 04, 2014 at 12:32:06PM +0300, Yavor Doganov wrote: > [ Apologies for replying to myself again. ] > > Yavor Doganov wrote: > > - The autorelease pool should be created in the constructor, before > > the first object is allocated. That's openvpn_plugin_open_v1, > > Actually, after looking more into this and reading openvpn-plugin.h, I > see that the upstream patch is correct here. ctx->config is manually > released in openvpn_plugin_close_v1, so that's perfectly fine. > > There are a few other potential issues with initialization -- not > assigning self to the result of super or [self init] and using [self > init] when [super init] should be used. These are easily fixable.
Hi Yagor, Thanks for your help!! I'll apply the patch and do some testing next week, hopefully closing this. Cheers, Alberto -- Alberto Gonzalez Iniesta | Formación, consultoría y soporte técnico mailto/sip: a...@inittab.org | en GNU/Linux y software libre Encrypted mail preferred | http://inittab.com Key fingerprint = 5347 CBD8 3E30 A9EB 4D7D 4BF2 009B 3375 6B9A AA55 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
