[ Apologies for replying to myself again. ] Yavor Doganov wrote: > - The autorelease pool should be created in the constructor, before > the first object is allocated. That's openvpn_plugin_open_v1,
Actually, after looking more into this and reading openvpn-plugin.h, I see that the upstream patch is correct here. ctx->config is manually released in openvpn_plugin_close_v1, so that's perfectly fine. There are a few other potential issues with initialization -- not assigning self to the result of super or [self init] and using [self init] when [super init] should be used. These are easily fixable. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
