Hi!
The attached patch adds appropriate acknowledgement of the developers of the
oxygen icon theme to d/copyright. That part is clearly a bug and needs fixing.
As for the rest of the complaints about the sources for the icons -- these are
unsubstantiated allegations about what is or is not the preferred form of
modification. Not all artists draw things in svg (with say inkscape) and then
export the result to png and stop there.
We can look at the origin VCS for these icons and look at the workflow of the
artists involved and see what they consider automatically generated (not-
precious, not checked into VCS) and what they consider to be manually created
(precious, checked into the VCS). We can look for build systems that do
automated conversions.
Ultimately, however, to report a bug that there is no source available for a
file without a statement from the upstream that there is indeed a missing
source file requires us to make assumptions. It would be better to assume that
the developers were good artists who liked pixel editing programs rather than
assuming they were incompetent or malicious and either lost or hid sources.
Reasonable assumptions can be made in either direction -- in the absence of
statements from the upstream developers saying that the PNG is not their
preferred form of modification, it is reasonable to assume it is in many cases.
Specifically in this package:
The oxygen icon theme does not appear to use automated tools to convert
between svg and png format [1]. It is reasonable to assume that hand re-
touching of the png format images is undertaken by the artists involved as is
common practice and particularly in the absence of tools to do this in the
oxygen svn. The preferred form of modification is then the png itself.
[1] http://websvn.kde.org/trunk/kdesupport/oxygen-icons/
The following files carry metadata indicating that they were exported from
inskcape presumably as an svg→png conversion. There appears to be no SVG
source available for them and once again we do not know if they have been
later manipulated by hand in some other image editing software anyway.
Inkscape may have never actually saved the SVG but just been used as an image
editor and the output exported as PNG directly. Without a statement from
keepassx upstream to say that there are missing SVG sources, it seems
reasonable to assume once again that these are sources.
./share/keepassx/icons/text_bold.png
./share/keepassx/icons/manual.png
./share/keepassx/icons/text_italic.png
./share/keepassx/icons/go-home.png
./share/keepassx/icons/keepassx_small.png
./share/keepassx/icons/help_about.png
./share/keepassx/icons/keepassx.png
./share/keepassx/icons/text_under.png
The last remaining problematic image is:
./share/keepassx/icons/clientic.png
We know nothing about this image and it contains no metadata. Why does the bug
reporter assume that this image was not constructed in a pixel editing program
by someone with some artistic skill?
I think we would do better to take upstreams at their word that they are
giving us the sources for icons in png format rather than to accuse them of
either maliciously or incompetently withholding the source files, particularly
when one of the upstream developers is a DD and so more aware of these issues
than average. I'm happy to be proved wrong on any individual case here -- but
perhaps the simple questions should be asked of upstream first rather than
filing release critical bugs without fact checking.
cheers
Stuart
--
Stuart Prescott http://www.nanonanonano.net/ stu...@nanonanonano.net
Debian Developer http://www.debian.org/ stu...@debian.org
GPG fingerprint BE65 FD1E F4EA 08F3 23D4 3C6D 9FE8 B8CD 71C5 D1A8
GPG fingerprint 90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7
--- copyright-orig 2013-01-26 01:39:24.332915540 +0000
+++ copyright 2013-01-26 01:39:10.384845507 +0000
@@ -161,2 +161,21 @@
* code for free from the Internet.
+
+The directory share/keepassx/icons directory contains icons from the Oxygen
+Icon theme:
+
+ Copyright (C) 2007 Nuno Pinheiro <n...@oxygen-icons.org>
+ Copyright (C) 2007 David Vignoni <da...@icon-king.com>
+ Copyright (C) 2007 David Miller <mil...@oxygen-icons.org>
+ Copyright (C) 2007 Johann Ollivier Lapeyre <joh...@oxygen-icons.org>
+ Copyright (C) 2007 Kenneth Wimer <kw...@bootsplash.org>
+ Copyright (C) 2007 Riccardo Iaconelli <ricca...@oxygen-icons.org>
+
+ This library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 3 of the License, or (at your option) any later version.
+
+On Debian systems, the complete text of the GNU Lesser General Public
+License version 3 can be found in /usr/share/common-licenses/LGPL-3
+
