Hi Philip,
I made a push request[1] but I missed the fact that it fails.
It was due to the tests being run with sh(dash) instead of bash or
busybox sh.
So, I just fixed the code so that it works with any of these 3 shells
and I update the testsuite. Now, all the tests pass on salsa.
Let me know if this is ok for you. As d-i is already in RC, if
you prefer, I can revert the longint2human part that modifies
some information, and only keep the human2longint that adds
some new input that were forbidden before (no change for what
was already accepted). The longint2human part can be added after
the release if you think it is too intrusive (or if it must be
adapted)
Regards
Vincent
[1] https://salsa.debian.org/installer-team/partman-base/-/merge_requests/6
Le 27/03/2023 à 02:07, Philip Hands a écrit :
Hi Vincent,
I've applied your patch and pushed it to to salsa (my fork) to get it
built by CI ... which failed, because of the use of ${X/...} and
${X:...}, which it seems busybox doesn't like.
So I've changed that code, and added a couple of other tweaks, as you
can see here:
https://salsa.debian.org/philh/partman-base/-/commits/bug/913431
Perhaps you can look at the result, and check that it still does what
you intended, and pick anything you like out of the rest.
>
BTW the working pipeline build includes the creation of a mini-ISO image
(once one kicks branch2repo into action), that should allow this code to
be tested in D-I:
https://salsa.debian.org/installer-team/debian-installer/-/jobs/4087808/artifacts/file/public/gtk-mini.iso
HTH
Cheers, Phil.
