Hi Philip,
Le 27/03/2023 à 02:07, Philip Hands a écrit :
Hi Vincent,
I've applied your patch and pushed it to to salsa (my fork) to get it
built by CI ... which failed, because of the use of ${X/...} and
${X:...}, which it seems busybox doesn't like.
So I've changed that code, and added a couple of other tweaks, as you
can see here:
https://salsa.debian.org/philh/partman-base/-/commits/bug/913431
Perhaps you can look at the result, and check that it still does what
you intended, and pick anything you like out of the rest.
There were a problem: "expr substr" requires the 'length' argument
(it is optional for the ${s:..} construct)
So, I restarted from my previous work (as said in the bug report just
before your message, I already saw that ${X:...} and ${X/...} do not
work), switch from "cut -c ..." to "expr substr ..." [with all arguments]
and applied some of your tweaks.
The resulting state can be seen here:
https://salsa.debian.org/vdanjean/partman-base/-/tree/bug/913431-tested
BTW the working pipeline build includes the creation of a mini-ISO image
(once one kicks branch2repo into action), that should allow this code to
be tested in D-I:
https://salsa.debian.org/installer-team/debian-installer/-/jobs/4087808/artifacts/file/public/gtk-mini.iso
I made my tests as suggested by Emanuele Rocca, i.e. by overwriting
the modified file (base.sh) during the installation before running the
partition step.
I confirm I successfully created partition and LVM LV with power-of-two
units.
I noticed that "human2longint" is ready to handle numbers with spaces in it
(such as 30 000 kB), but "valid_human" does not accept them (no spaces but
before the unit). I not sure if this is intended or not.
Thanks you very much for your feedback
Vincent
HTH
Cheers, Phil.
