Oliver Freyermuth <freyerm...@physik.uni-bonn.de> (2023-04-08): > I can confirm that the question is not shown anymore, and installation > proceeds unattendedly, so the patched versions test fine on my end > :-). > > During installation, when switching to a tty and running "hostname > -f", I see the FQDN assigned via the hostname parameter, as expected.
Great, thanks.
> Then of course we also need to test what happens without the
> "hostname=" paraemter on the kernel commandline. I removed it,
> re-tried, and the question was shown again, so that also seems to work
> as expected.
>
> Interestingky, without the "hostname=" parameter, running hostname on
> a tty (while the question is shown) echoes:
>
> ~ # hostname
> ?
I found that part slightly strange. From earlier on IRC:
<kibi> fun how we get '(none)' by default and '?' instead with -s.
<kibi> ('?' comes from safe_gethostname depending on uts.nodename[0])
so I'm not exactly sure why you're getting '?' by default instead of
'(none)'. Maybe that's once you've reached the network step and stuff
has happened? My observations were right after setting a keymap,
switching to a VT.
For context, I was initially wondering which options were supported by
busybox's hostname, hence my looking into this. (Wasn't entirely sure
how safe / future-proof hardcoding “(none)” would be; still unclear at
this point, but I haven't spent much time on this.)
> However, that "question mark hostname" is also shown when doing this
> with Bullseye, so that seems to be expected behaviour.
That part's reassuring.
> Seeing the unintrusiveness of the patch, and taking into account that
> adapting existing deployment software can be avoided (there's
> certainly much more affected tooling out there), that feels like a
> good approach to me, too.
Clearly! Initially I was worried about stashing a special case into the
labyrinth (that the parsing code is) that's below, I didn't think of
actually checking the effects of the linux's having consumed that
parameter would have…
Cheers,
--
Cyril Brulebois (k...@debian.org) <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
signature.asc
Description: PGP signature
