On Mon, Nov 27, 2017 at 3:08 PM, Raphael Hertzog <hert...@debian.org> wrote: [...] > I pushed a pu/kernel-cmdline-preseed branch implementing the preseeding > out of /proc/cmdline. It's more elaborate than Mathieu's patch > (https://paste.ubuntu.com/26034695/) in that it is able to handle > multi-word values. > > I tested it locally and it fixes the rescue mode for me. For > consistency, I renamed the command and the udeb, but the only place > where it matters is in "debian-installer" itself where we have to update > the package name. >
That will work on most arches, but not on kfreebsd/*. That said, the easy fix would be to look at both environment and /proc/cmdline. I *think* you only really need -e 's/\([^ =]*=[^ "]\)/\n\1/g' -e "s/\([^ =]*=[^ ']\)/\n\1/g" to multiline the entries and appropriately handle any multiword. With my limited testing it seemed to work well, and would be less complex than your solution ;) Did I miss some important corner-case? -- Mathieu Trudel-Lapierre <mathieu.trudel-lapie...@canonical.com> Freenode: cyphermox, Jabber: mathieu...@gmail.com 4096R/65B58DA1 818A D123 0992 275B 23C2 CF89 C67B B4D6 65B5 8DA1
