On Thursday 17 July 2008, Ryan Niebur wrote:
> Here is a patch that adds support for RAID6 and RAID10 to the debian
> installer.

Thanks a lot.

You seem to have moved two functions in that patch which have remained 
more or less the same. This makes review more difficult then it should 
be.

Could you please submit a patch that contains only the actual functional 
changes? And if you think the move is needed, then do that in a separate 
patch first or after without any changes in the functions?

From what I can tell reading around that noise the patch looks quite sane 
and contains a nice generalization of the create function. I think we 
should certainly consider this for Lenny. Main bottleneck will be the 
translation effort required.

Thanks,
FJP

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to