Hi, was there any news regarding the integration of the timelapse module? A couple of weeks ago there was a single commit seemingly containing all necessary changes to integrate the timelapse module https://github.com/fhrtms/darktable/commit/d82610a
Simply applying the patch file of it (https://github.com/fhrtms/darktable/commit/d82610a.patch) with: patch -p1 < d82610a.patch to the master branch of the darktable git repository seems to work I build my Version with the Arch AUR package which does not use the build script itself, instead it executes a standalone cmake command followed by a simple make (see here: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=darktable-git) the only thing i needed to append was: -Wno-tautological-compare -Wno-error=shadow to "-DCMAKE_C_FLAGS" Not sure about the shadow one, but the "-Wno-tautological-compare" should be fixable https://github.com/fhrtms/darktable/blob/master/src/views/timelapse.c#L311 seems to be the problem (to me that doesnt make much sense as a != a always returns false, hence the tautological error, and the if case should be completely removable leaving the else case as the default.) I dont have any Timelapse sequences on hand to really test it though Not sure if the code is up to the darktable standards, would love to hear back from you guys and see it integrated. best regards On 12/15/2016 10:38 PM, Christian Mandel wrote: > Am 06.12.2016 um 22:27 schrieb Florian Aders: >> Hi, >> >> I ported the code in https://github.com/fhrtms/darktable to the (at >> the point >> in time) latest master of darktable (resides in branch "timelapse" in my >> GitHub - repo (https://github.com/EleRas/darktable). >> >> At the same time I contacted the author of the original code, who told >> me that >> the version he uploaded on GitHub was not the latest version he had >> and that > > I once built that version on my old work computer (Ubuntu 12.x I would > guess), and indeed it was not the same version shown in the video. > Furthermore, I was not able to figure out how to use it, so I lost > interest. But it seemed a similar approach to what > https://lrtimelapse.com/ is providing for lightroom. > > I just wanted to say thank you for caring about this one, since there > are several unfinished time lapse sequences on my hard disk :-) > > Best regards > > Chris > > >> he wanted to continue working on it. Due to this I did no further work >> on it, >> since I don't know the needed math behind it enough. In a similar >> matter, I >> did not want to submit this for inclusion in darktable since it isn't >> finished. >> >> I'll try to update it to latest master in the next days (maybe on the >> weekend), since I quite like, that it has no further dependencies and >> integrates nicely into darktable. >> >> Florian >> >> On Dienstag, 6. Dezember 2016 20:59:18 CET Alexandre Jullien wrote: >>> Hi, >>> >>> For timelapse-darktable, indeed it does quite the same job but with >>> external tools (Java, octave, image magic) >>> Its main drawback is that there is no integration in darktable directly, >>> but it was OK for my use thou... Using darktable GUI fit the key frames >>> only. >>> Second drawback, it's using xmp as interface, so submitted to change >>> in iop >>> filters... >>> It was working up to 05/2015 then I didn't update the program. >>> Finally the code was on Google code which is closed project now... I >>> have >>> to move it to GitHub to be updatable... >>> >>> Conclusion, if you want to revive the integrated timelapse feature >>> inside >>> darktable, I will be very happy to use and give support if needed >>> (not for >>> the coding but for the maths/timelapse theory). >>> >>> Cheers >>> >>> Alexandre >>> >>> Le mar. 6 déc. 2016 17:35, Pascal Obry <pas...@obry.net> a écrit : >>>> Le mardi 06 décembre 2016 à 12:21 +1100, Robert William Hutton : >>>>> I've also been wondering what happened to that feature, as the video >>>>> looked really promising. >>>>> >>>>> The code on the timelapse branch in the >>>>> https://github.com/EleRas/darktable repo didn't build for me though. >>>>> ;( >>>> >>>> I also feel sad about this! It would be a really nice addition to >>>> darktable and I don't understand spending so much time on such a large >>>> development without finishing the last step: integration. >>>> >>>> I really hope the original author will come back here! >>>> >>>> -- >>>> >>>> Pascal Obry / Magny Les Hameaux (78) >>>> >>>> The best way to travel is by means of imagination >>>> >>>> http://www.obry.net >>>> >>>> gpg --keyserver keys.gnupg.net --recv-key F949BD3B >>>> >>>> __________________________________________________________________________ >>>> >>>> _ >>>> darktable developer mailing list >>>> to unsubscribe send a mail to >>>> darktable-dev+unsubscr...@lists.darktable.org >>> >>> ___________________________________________________________________________ >>> >>> darktable developer mailing list >>> to unsubscribe send a mail to >>> darktable-dev+unsubscr...@lists.darktable.org >> >> > > > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
