On Tue, Feb 9, 2016 at 10:07 PM, Chris Siebenmann <c...@cs.toronto.edu> wrote: > Starting from commit c145922aa6110a09d32e75230172f350a312caec, 'rawspeed: > offset==size is not valid', darktable can't read my NEFs; it rejects them > with eg: > > [rawspeed] NEF Decoder: Invalid strip byte count. File probably > truncated. > [temperature] failed to read camera white balance information from > `DSC_1101.NEF'! > [temperature] failed to read camera white balance information from > `DSC_1101.NEF'! > [rawspeed] NEF Decoder: Invalid strip byte count. File probably > truncated.
Thanks for reporting this. I've been making rawspeed much stricted about checking bounds and other stuff to avoid crashes and a few of those then reveal wrong assumptions elsewhere in the code. Current master should have this fixed. If you find any other cases let us know. > This is the case for all of the NEFs that you can find here: > http://www.cs.toronto.edu/~cks/tmp/darktable/ Thanks for pointing us towards sample files. This is probably a good time to remind everyone that we have relatively poor coverage of sample files to test that we didn't break anything between versions. Coverage is currently 61%, which means that for 39% of the cameras we do support right now the next version of darktable may have broken support for them because we have no way of testing it. Here's the current support list: http://www.darktable.org/resources/camera-support/ If you own or have access to one of the cameras that have a NO in the first column please submit a sample file to rawsamples.ch. Anything will do but a well exposed and colorful file is preferred (because it's better for testing and because we do end up looking at these files quite a few times...). It's also very easy to add missing white balance presets or noise profiling if you're willing to take a small set of simple test shots. Cheers, Pedro ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
