On Fri, Jan 29, 2016 at 8:48 PM, Ulrich Pegelow <ulrich.pege...@tongareva.de> wrote: > Hi, > > Pascal and I had a short chat about the position of liquify (new module in > master) and ashift (PR stage) in the pixelpipe. > > For ashift, which I am working on, the best position is after lens > correction and before the flip module. Reason: the module will extract > straight lines for perspective correction, so it would profit from > distortion correction in the lens module. It should come before flip as it > needs to be defined in camera coordinate system - it's not invariant to > image flipping. > > My thoughts on the position of liquify in pixelpipe: it should probably come > after lens correction as it could take advantage of a defined input state > with corrected lines. Also, as discussion in PR 1129 shows, there are plans > to move manual perspective correction from crop&rotate to lens correction. > If liquify comes before lens it might make perspective correction more > difficult. I would suggest to have liquify after ashift so warping in > liquify would not interfere with line detection in ashift. > > Other thoughts? I have suggested the same during liquify pr: https://github.com/darktable-org/darktable/pull/1088#issuecomment-172325722
That comment: >Does this module have any assumptions about it's working color space, does it >need to work in camera rgb? lab? >Also, is it safe to assume that lens correction will be applied in direct >direction (i.e. correct), not in reverse (i.e. distort) > >Based on answers to these questions i see 3 possible places for liquify place >in pipe: >1. before spot removal, like now >2. before lens correction >3. after lens correction, before input color profile >4. after crop and rotate? > >Personally, 3. seems like the best place to me. >Or, at least comment in tools/iop_dependencies.py needs fixing :) > > Ulrich Roman. > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
