Hi,
Pascal and I had a short chat about the position of liquify (new module
in master) and ashift (PR stage) in the pixelpipe.
For ashift, which I am working on, the best position is after lens
correction and before the flip module. Reason: the module will extract
straight lines for perspective correction, so it would profit from
distortion correction in the lens module. It should come before flip as
it needs to be defined in camera coordinate system - it's not invariant
to image flipping.
My thoughts on the position of liquify in pixelpipe: it should probably
come after lens correction as it could take advantage of a defined input
state with corrected lines. Also, as discussion in PR 1129 shows, there
are plans to move manual perspective correction from crop&rotate to lens
correction. If liquify comes before lens it might make perspective
correction more difficult. I would suggest to have liquify after ashift
so warping in liquify would not interfere with line detection in ashift.
Other thoughts?
Ulrich
___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
