Hi Takashi, On May 28 21:44, Takashi Yano wrote: > Hi Corinna, > > On Thu, 28 May 2015 21:09:32 +0900 > Takashi Yano wrote: > > > On Thu, 28 May 2015 13:47:28 +0200 > > Corinna Vinschen wrote: > > > > > I created another version of your patch which avoids duplicating the > > > tested handle and makes the test-and-close-handle operation atomic: > > > > > Does that look ok? It fixes the reported problem for me. > > > > Oops! I have just sent another patch. > > Your patch also works nicely for me.
I applied this patch. I'm not comfortable with removing the SIGHUP handling from slave::read in favor of just setting errno to EIO. EIO seems wrong here. Not being able to access the pipe anymore should be equivalent to a hangup. Alternatively the return code from the Windows function should be checked for ERROR_BROKEN_PIPE, perhaps, but that introduces some more code, Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat
pgp1dAoNvq0cx.pgp
Description: PGP signature
