Poul-Henning Kamp wrote:
In message <[EMAIL PROTECTED]>, Alexander Leiding
er writes:
Log:
Import OpenBSD's sysctl hardware sensors framework.
I would like to register a complaint about this commit.
When this was discussed I objected that this entire pile of crap does
not belong in the kernel.
I still think this is a festering junkpile that does not belong in
the kernel, and that his should be backed out, until a proper
architectural solution has been found.
Adding a new bogus type of device tree just because on cannot be
bothered to do things right, is the road that leads to things like
SYSV IPC and away from a sustainable architecture for an operating
system which is here for the long term.
Please back this out.
I'd have to agree that these changes need more buy in and review. I
recall many folks voiced complaints when the work was submitted to p4.
There are basic design issues that need to be resolved such as whether
code that's been added to the kernel is needed (instead of doing
user-space drivers). Having kernel support is usually dependent on
whether it's infeasible to do the work in user space and/or using the
results within the kernel. I also took a quick glance at the 2 drivers
that were added and see multiple issues that indicate this code needs
more review (possible div-by-zero, lack of newbus integration, probing
i2c devices, etc).
I was very happy to see this SoC project happen and I think users could
benefit from a common sensor framework but I'd like to see one that is a
better fit to freebsd.
Sam
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
