On Fri, Jun 21, 2013 at 3:08 PM, Vincent Untz <vu...@suse.com> wrote:
> Hi Victor, > > Le vendredi 21 juin 2013, à 13:14 -0500, Victor Lowther a écrit : > > Hi, Vincent: > > > > I was running through one of mt semi-regular smoketests of the Pebbles > > codebase when I noticed that the admin node had transitioned into problem > > state. A quick glance at /var/log/install.log showed that the admin node > > sanity check (at /opt/dell/bin/barclamp_test.rb) was failing one of the > > proposal_delete tests -- specifically: > > > > node_manipulate: Success creating role without test-multi-rest > > node_manipulate: Success: delete test_p1 proposal > > node_manipulate: Value: ["", 404] Expected: ["Failed to apply the > proposal > > to: dtest-machine-1.dell.com ", 405]: Failed to delete active: test_p1 > > Right, looking at what barclamp-test is doing, this is kind of expected > given the fix we're talking about. My understanding, and this is what > the webui enforces (since forever?), is that it should not be possible > to delete a proposal before deactivating it. And the test as it is > written in barclamp-test breaks this assumption. If the assumption is > wrong (it sounds sane to me, though), then we should also fix the UI Think about it this way: If you delete a proosed configuration, should it affect the active configuration that was based on it? As the API was originally designed, that answer was no. > > I looked at the install-chef-suse.sh ,and saw that the barclamp_test.rb > > call had been conditionalized with a note to the effect that it was > failing > > -- we probably should not be doing that. > > > > When you were editing the code that handles proposal deactivation and > > deletion, were you running the barclamp_test.rb to verify that the > proposal > > API was still passing the tests? > > I'm only using what's setup by install-chef-suse.sh, so indeed, no > barclamp-test here... I'm not totally sure why it was breaking a long > time ago and if it's still the case, though In that case, would it be possible to reenable the mandatory API testing to avoid these sorts of issues in the future? > > Vincent > > -- > Les gens heureux ne sont pas pressés. > > _______________________________________________ > Crowbar mailing list > Crowbar@dell.com > https://lists.us.dell.com/mailman/listinfo/crowbar > For more information: http://crowbar.github.com/ >
_______________________________________________ Crowbar mailing list Crowbar@dell.com https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/
