OK, I wound up having to close and recreate the pull requests. Sorry about that.
> -----Original Message----- > From: crowbar-bounces On Behalf Of Lowther, Victor > Sent: Wednesday, June 05, 2013 5:01 PM > To: vu...@suse.com > Cc: crowbar > Subject: Re: [Crowbar] "Rework how we allocate disks to barclamps" pull > request review > > Something Weird is happening on github -- I see 2 branches with identical > names > for this pull request branch. I will probably zap these and resubmit. > > > -----Original Message----- > > From: Vincent Untz [mailto:vu...@suse.com] > > Sent: Wednesday, June 05, 2013 4:51 PM > > To: Lowther, Victor > > Cc: crowbar > > Subject: "Rework how we allocate disks to barclamps" pull request > > review > > > > Hi Victor, > > > > (sending this here, because you're not on irc anymore) > > > > FWIW, I'm not sure why, but github doesn't show me the updated patch > > in the pull request, so before things get merged, I guess we should > > figure this out. I looked directly at the commits in your branches instead. > > > > I think I'm fine with all patches now, except for the barclamp-cinder > > one where I left a comment on your commit: I think there's an issue in > > a select call. See > > https://github.com/VictorLowther/barclamp- > > > cinder/commit/ac1f5bd214559dddfa5b06fc15059568ff7f0118#commitcommen > > t-3363551 > > > > And thanks for your work on this: this does solve one important issue, > > and it's nice to see this get fixed! > > > > Vincent > > > > -- > > Les gens heureux ne sont pas pressés. > > _______________________________________________ > Crowbar mailing list > Crowbar@dell.com > https://lists.us.dell.com/mailman/listinfo/crowbar > For more information: http://crowbar.github.com/ _______________________________________________ Crowbar mailing list Crowbar@dell.com https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/
