Hi Victor,

(sending this here, because you're not on irc anymore)

FWIW, I'm not sure why, but github doesn't show me the updated patch in
the pull request, so before things get merged, I guess we should figure
this out. I looked directly at the commits in your branches instead.

I think I'm fine with all patches now, except for the barclamp-cinder
one where I left a comment on your commit: I think there's an issue in
a select call. See
https://github.com/VictorLowther/barclamp-cinder/commit/ac1f5bd214559dddfa5b06fc15059568ff7f0118#commitcomment-3363551

And thanks for your work on this: this does solve one important issue,
and it's nice to see this get fixed!

Vincent

-- 
Les gens heureux ne sont pas pressés.

_______________________________________________
Crowbar mailing list
Crowbar@dell.com
https://lists.us.dell.com/mailman/listinfo/crowbar
For more information: http://crowbar.github.com/

Reply via email to