On Sun, Apr 11, 2021 at 12:48 PM Jim Meyering <j...@meyering.net> wrote: > > On Sun, Apr 11, 2021 at 10:38 AM Pádraig Brady <p...@draigbrady.com> wrote: > ... > > The changes didn't introduce any new instances > > of that const declaration style (apart from the new forward declaration), > > but you're right we should be consistent here. > > This seems like the perfect thing for a syntax check, > > so I added a simple one as follows: > > > > +# Prefer the const declaration form, with const following the type > > +sc_prohibit-const-char: > > + @prohibit='const char \*' \ > > + in_vc_files='\.[ch]$$' \ > > + halt='Use char const *, not const char *' \ > > + $(_sc_search_regexp) > > > > I adjusted all files to pass and pushed. > > Great. Thank you!
Incidentally, running on Fedora 34 built with gcc-11(upcoming, probably irrelevant), and with an update-to-latest-gnulib patch, this ls test fails: tests/ls/stat-free-color Here's the log:
stat-free-color.log
Description: Binary data
