On Mon, 2 Nov 2026 02:35:42 GMT, ExE Boss <[email protected]> wrote: >> Finally, given how this PR manages to keep these changes as internal >> implementation details without impacting any sub-classes of >> `InputStreamReader`, I think a CSR won't be required. > >> Finally, given how this PR manages to keep these changes as internal >> implementation details without impacting any sub-classes of >> `InputStreamReader`, I think a CSR won't be required. > > It does however introduce `readAllAsString` as an override in > `InputStreamReader`.
Hello @ExE-Boss, >> Finally, given how this PR manages to keep these changes as internal >> implementation details without impacting any sub-classes of >> InputStreamReader, I think a CSR won't be required. > > It does however introduce readAllAsString as an override in InputStreamReader. The change that we settled down in this PR is merely an implementation detail. Overridding a method without changing its specification, or signature or any exceptions that get thrown doesn't require a CSR. Neither is the change sufficiently large or broad (going by what's stated in https://wiki.openjdk.org/spaces/csr/pages/31850534/Main) to warrant one. So I think it's OK to go ahead with the change without a CSR. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32264#issuecomment-6660941377
