On Fri, 6 Nov 2026 08:17:15 GMT, Matthias Baesken <[email protected]> wrote:
>> We potentially leak a handle in case of failing malloc. >> >> Additionally, GetFinalPathNameByHandleW can fail and return 0. Then we >> should free a newly allocated buffer. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Some suggestions by alanb src/java.base/windows/native/libjava/canonicalize_md.c line 169: > 167: > 168: if (h != INVALID_HANDLE_VALUE) { > 169: WCHAR* newFinalPath = NULL; newFinalPath is a left over from the first iteration so can be removed, the rest looks fine. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33752#discussion_r4490600759
