On Fri, 30 Oct 2026 14:11:38 GMT, Alan Bateman <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improve code style > > src/java.base/share/classes/java/io/RandomAccessFile.java line 530: > >> 528: return 0; >> 529: } >> 530: long newpos = len - pos > n ? pos + n : len; > > I think this is a lot less readable. Can you keep pos = getFilePosition() and > len = length() rather than assigning them in the if statement. Then you can > add a long remaining or long skipped so it's much more readable (len - pos > > n is just too subtle and hard to read). Improved the coding style in 03d0a09290d. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33649#discussion_r4440441764
