On Fri, 16 Oct 2026 05:19:50 GMT, Benjamin Peterson <[email protected]> 
wrote:

> The branch removed here is dead because `read()` should never return `0` if 
> `remaining > 0`. The dead code also had a bug: Casting the `int` result of 
> `read()` to `byte` is wrong when the result is 255.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

My main concern is blocking streams and channels, so I haven't thought too much 
about non-blocking cases. I closed this because I assumed the change I proposed 
here would be obviated by whatever happens in 
https://bugs.openjdk.org/browse/JDK-8387022. Is there something else that it 
would be helpful for me to do?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33401#issuecomment-6224676024

Reply via email to