On Fri, 16 Oct 2026 16:46:38 GMT, Joe Darcy <[email protected]> wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java >> line 493: >> >>> 491: // handles >>> infinities too >>> 492: Double.isNaN(trialResult) || >>> 493: (Math.abs(trialResult) > (0x1.0p-14) && // >>> Float16.MIN_VALUE, avoid subnormal range >> >> Suggestion: >> >> (Math.abs(trialResult) > (0x1.0p-14) && // Float16.MIN_NORMAL, >> avoid subnormal range >> >> >> Any reason for using the static field in the comment but not in the code? > > Good catch; I'll fix that in the next push. > > Since the code needs the value as a double and it is a constant, I thought > using the double literal was preferable to `Float16.MIN_NORMAL.doubleValue()` > or similar expression. Makes sense. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33392#discussion_r4297163522
