On Thu, 3 Sep 2026 03:43:04 GMT, Dean Long <[email protected]> wrote:
>> Quan Anh Mai has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains six commits: >> >> - Merge branch 'master' into int128 >> - C++17 >> - Merge branch 'master' into int128 >> - Merge branch 'master' into int128 >> - whitespace >> - Implement Int128T addsub > > src/hotspot/share/opto/int128tnode.cpp line 47: > >> 45: proj_types[1] = TypeLong::LONG; >> 46: return TypeTuple::make(2, proj_types); >> 47: } > > I wish there was a way to make these tuple types constexpr. Should we at > least compute this once and cache the result, like we do for other tuple > types? You are right, we have `TypeTuple::LONG_PAIR`, I have changed to using it instead. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31008#discussion_r3921093081
