On Tue, 1 Sep 2026 17:31:38 GMT, Naoto Sato <[email protected]> wrote:
>> This PR implements [JEP 540: Simple JSON API >> (Incubator)](https://openjdk.org/jeps/540). >> >> It adds the `jdk.incubator.json` module which provides APIs for reading and >> writing JSON documents as specified by [RFC >> 8259](https://datatracker.ietf.org/doc/html/rfc8259). This is an incubating >> API. >> >> API documentation: >> https://cr.openjdk.org/~naoto/json/javadoc/api/jdk.incubator.json/module-summary.html >> Co-authored-by: Justin Lu >> ([@justin-curtis-lu](https://github.com/justin-curtis-lu)), Stuart Marks >> ([@stuart-marks](https://github.com/stuart-marks)) >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Naoto Sato has updated the pull request incrementally with two additional > commits since the last revision: > > - Merge remote-tracking branch 'jdk-sandbox/json' into > JDK-8381976-Implementation-for-Simple-JSON-API > - Use SequencedMap type for the member field src/jdk.incubator.json/share/classes/jdk/incubator/json/impl/JsonValueSupport.java line 45: > 43: * if it was parsed. Otherwise, return -1. > 44: */ > 45: int offset(); I might be wrong, but looking at the PR it seems like these are only used for error messages / debug information. I suspect that it would be cleaner to instead of "exposing the internals" here (i.e. returning a mutable array, and separating offset etc) to replace these two methods with a "String toErrorString()" or a "void renderError(StringBuilder sb)". Another option is "CharSequence origin()". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32282#discussion_r3913257053
