On Thu, 20 Aug 2026 15:02:49 GMT, Alan Bateman <[email protected]> wrote:
>> Dušan Bálek has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Test updated.
>
> test/jdk/tools/jlink/JLinkToolProviderTest.java line 71:
>
>> 69: readyLatch.await();
>> 70: } finally {
>> 71: startLatch.countDown();
>
> FYI, instead of two latches, you could just use a Phaser and use
> arriveAndAwaitAdvance to have each task attempt the jlink command at around
> the same time.
Test modified.
> test/jdk/tools/jlink/JLinkToolProviderTest.java line 86:
>
>> 84: checkJlinkOptions("--help");
>> 85: checkJlinkOptions("--list-plugins");
>> 86: checkConcurrentAccess(3);
>
> Future maintainers we will wonder why "3" was picked, maybe
> Runtime::availableProcessors / 4 would be better.
Test modified.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32469#discussion_r3823243326
PR Review Comment: https://git.openjdk.org/jdk/pull/32469#discussion_r3823243621
