On Thu, 18 Jun 2026 07:32:00 GMT, Manuel Hässig <[email protected]> wrote:

> The test `java/lang/instrument/GetObjectSizeIntrinsicsTest.java` crashed in 
> our CI when run with `-Xcomp` and `-XX:+VerifyOops` on aarch64. On aarch64, 
> `-XX:+VerifyOops` increases the code size by a large amount and since this 
> test creates large object arrays, there are loads of oops to check. However, 
> because this is a test about object size and does nothing interesting with 
> the oops, I propose to disable the test for `-XX:+VerifyOops`. This prevents 
> the failures, but does not detract too much from coverage.
> 
> There are alternatives to this, though. #7214 fixed the same kind of failure 
> by restricting the compilation to the test method and thereby saving code 
> cache. However, I still got crashes in testing with this solution, so I took 
> the more heavy-handed route of disabling the test for the flag. The other 
> alternatives listed in #7214, I did not pursue for the same reason.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Thanks for fixing this, Manuel!

-------------

Marked as reviewed by rcastanedalo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/31567#pullrequestreview-4522823565

Reply via email to