On Thu, 11 Jun 2026 14:28:20 GMT, Alan Bateman <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2798 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - 8386239: [lworld] Update jdk/java/util/Arrays/ArraysEqCmpTest.java >> >> Reviewed-by: liach >> - 8386242: [lworld] Simplify and clarify StrictProcessor >> >> Reviewed-by: dsimms >> - 8386140: [lworld] FieldReflector using wrong Class argument >> >> Reviewed-by: alanb, dsimms >> - 8386216: [lworld] Rollback meaningless diff in EventClassBuilder >> >> Reviewed-by: dsimms >> - 8385170: [lworld] Serialization spec needs to allow abstract value >> classes like Number >> >> Reviewed-by: liach >> - 8385980: [lworld] Standardize pattern for preview value class generation >> >> Reviewed-by: liach >> - 8386086: [lworld] >> sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java should be >> removed from problem list >> >> Reviewed-by: liach, dcubed >> - Merge >> >> Merge jdk-28+1 >> - 8386090: [lworld] Redundant test changes in lworld versus mainline >> >> Reviewed-by: vromero >> - ... and 2788 more: https://git.openjdk.org/jdk/compare/92298786...4d6d2888 > > src/java.base/share/classes/java/util/WeakHashMap.java line 59: > >> 57: * to hold the key cannot refer to a value object. >> 58: * Methods such as {@linkplain #get get} or {@linkplain >> #containsKey containsKey} >> 59: * will always return {@code null} or {@code false} >> respectively. > > I think this assumes a working equals method. A Dr. Evil crafted value class > with a cunning equals/hashCode would lead to get/containKey matching an > existing entry. I can mull over improvement this sentence. True, and that isn't necessarily a "Dr. Evil" - it's a valid use for users to construct a cheap lookup key. However, I don't have any good clue on improving this particular sentence. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3404630916
