On Fri, 22 May 2026 16:40:52 GMT, Paul Sandoz <[email protected]> wrote:
>> Xueming Shen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update sleef.md
>
> Nice work, very thorough.
>
> You have this comment in the tests:
>> // TANH is not included because VectorMathLibrary.SLEEF intentionally
>> rejects it.
>
> In `VectorMathLibrary.SLEEF`:
>
> if (op == TANH) {
> return false; // skip due to performance considerations
> }
>
>
> Are the performance considerations the same in the updated SLEEF version?
@PaulSandoz @erikj79 might need you re-approve. The last test-comment-only
commit/fix removed the 'ready' tag. thanks!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29703#issuecomment-4549898594
