On Tue, 26 May 2026 21:22:54 GMT, Naoto Sato <[email protected]> wrote:

>> Justin Lu has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add more mappings
>
> src/java.base/share/data/lsrdata/language-subtag-registry.txt line 43556:
> 
>> 43554: Prefix: sgn
>> 43555: %%
>> 43556: Type: extlang
> 
> This and some other new entries have `Preferred-Value`s. I'd expect those 
> values tested in the test case.

I didn't at first because the `ACCEPT_LANGUAGE` list only exercises a subset of 
the registry, and the test passed without any changes (for example, "yol" 
already existed in the registry but was not registered in the test). That said, 
I don't see a downside to increasing coverage, new mappings added in 
https://github.com/openjdk/jdk/pull/31285/commits/4157764c05c65bbd6bea9287e8ce891a5e9cfe98.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31285#discussion_r3307078428

Reply via email to