On Tue, 26 May 2026 14:12:10 GMT, Ashay Rane <[email protected]> wrote:

> Previously, the test expected a precise match between the produced and
> expected error messages, but such a check fails when the test fails for
> more than the expected reason, like when WiX is not available on
> Windows.  This patch changes the precise equality check with a substring
> check to work around the problem.
> 
> Validated this patch on a Windows box that doesn't have WiX available.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

I also think we need to skip tests which depends on WiX availability. Something 
similar to macOS signing test can be implemented. See 
https://github.com/openjdk/jdk/blob/master/test/jdk/tools/jpackage/macosx/SigningBase.java#L172.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31282#issuecomment-4549200286

Reply via email to