On Fri, 22 May 2026 22:11:41 GMT, Phil Race <[email protected]> wrote:
>> This removes the remaining uses of AppContext and AppContext itself. >> >> Some tests needed to be removed. Some seemed possibly still useful if I >> removed AppContext. >> >> The source code changes are fairly straightforward - almost entirely just >> deletions. >> >> The only interesting question is where to call SunToolkit.initEQ() >> It was usually initialized via the AppContext creation which isn't possible >> any more. >> >> The EQ can - in theory - be created lazily. >> But because the EQ needs to be created before any events are posted there >> aren't many places to choose from. >> I've put it in the SunToolkit constructor, and it is also - of course - >> still initialized in the static method to get the EQ. >> In postEvent() itself was the only other option that worked but then it is >> checked *every* time an event is posted. >> One of the 2 above seems to be always needed to cover all paths. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > > 8385347 Glad to see `test/jdk/java/util/logging/TestMainAppContext.java` go! I agree with the removal of this test. Disclaimer: I have not looked at the rest. ------------- PR Comment: https://git.openjdk.org/jdk/pull/31262#issuecomment-4536479847
