On Wed, 20 May 2026 01:56:46 GMT, Joe Darcy <[email protected]> wrote:
>> I'm assuming responsibility for getting @toxaart 's work from >> https://github.com/openjdk/jdk/pull/30984 integrated into mainline. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. I've had truly interesting discussions with @toxaart about how he reverse-engineered this floating-point function from way back. With pen and paper, he explained the logic in a way that took me from thinking, “this is pure magic” to “okay, I think I understand”. Do I really have the skills to do a proper review of this PR? No, I don’t. Few people do. But I deeply trust Anton’s mathematical abilities. I’m also sure that @jddarcy has the expertise to review it more thoroughly than I can, as well as having the right connections from way back to feel comfortable with this patch. Understanding this source, and fixing a bug in it, is about as non-trivial as it gets. Well done, Anton. ------------- Marked as reviewed by fbredberg (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/31210#pullrequestreview-4336827850
