On Wed, 13 May 2026 20:04:27 GMT, Coleen Phillimore <[email protected]> wrote:
>> This change makes UseCompactObjectHeaders default and switches the sense of >> the CDS archive naming. Now classes.jsa is with UseCompressedOops + >> UseCompactObjectHeaders (both default). Then theres: >> classes_nocoops.jsa >> classes_nocoh.jsa >> classes_nocoops_nocoh.jsa >> >> Hopefully someday we won't need the nocoh versions. >> >> Tested with tier1-8. With only one issue also fixed in this change, and no >> other new issues found. >> >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Fix CDSPlugin and CDSPluginTest, and VMOptionWarning.java test also. Still looks good to me. src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/CDSPlugin.java line 110: > 108: > 109: // The targetPlatform is the same as the runtimePlatform. > 110: // For a 64-bit platform, generate the non-compressed oop > CDS archive Comment is outdated, since now we generate all of the archives. test/jdk/tools/jlink/plugins/CDSPluginTest.java line 90: > 88: helper.checkImage(image, module, null, null, > 89: new String[] { subDir + "classes" + suffix }); > 90: } For a future RFE: Arguably, this test should test all 4 generated CDS archives now. ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/30322#pullrequestreview-4298305542 PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3248354911 PR Review Comment: https://git.openjdk.org/jdk/pull/30322#discussion_r3248405752
