On Mon, 11 May 2026 11:52:46 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Hi, Mikhail >> >> I've made `TestCleaner.java` similar to the other `@run main/manual` tests >> in `test/jdk/sun/security/smartcardio/`, which don't create a GUI >> explicitly. I admit that I don't know the specifics of how these tests are >> run, but AFAIK one can still bring up the gui using `jtreg -gui ...`. >> >> As with the other tests, `TestCleaner` "requires special hardware" (a real >> or simulated JavaCard). >> As long as a `CardTerminal.connect()` can be performed, `TestCleaner` runs >> on its own, and doesn't require manual intervention (or, IMO, instructions). > > My worry was the request to insert the card if it is not inserted. Could it > be a fail case instead? Then the test won't need any user interaction at all. > Alternatively, a popup would work better than the message since it is very > likely to be missed from my experience > > What do you think ? To echo Viktor, I'm still inclined to keep the same testing approach as the pre-existing tests. Possible changes/improvements to testing in this area can happen in a future PR. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30683#discussion_r3236852300
