On Wed, 13 May 2026 07:07:38 GMT, Christian Stein <[email protected]> wrote:
> Please review this test-only change to account for all jtreg-based frames in > `StackWalkTest.java` > > The change replaces a set of explicit class names with a package name-based > logic to filter out stackframe elements originating from jtreg. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). test/jdk/java/lang/StackWalker/StackWalkTest.java line 137: > 135: if (sf.getClassName().startsWith(prefix)) > 136: // safe to ignore > 137: return; This looks okay and should be okay as long as the the com.sun.javatest.regtest package continues to be used. I assume you'll fix the indentation of the if-statement as to early return is only when the condition is true. (As regards the var usage then it's not immediately obvious if prefix is a String or Package without looking at the declaration of infrastructurePackages. So I'd probably put the String type here.) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31144#discussion_r3232720663
