On Tue, 5 May 2026 06:16:49 GMT, Xueming Shen <[email protected]> wrote:

> Two internal helper methods recently added to AbstractVector are currently 
> showing up in the public javadoc of concrete vector classes:
> 
> - ByteVector
> - ShortVector
> - IntVector
> - LongVector
> - FloatVector
> - DoubleVector
> 
> The methods are:
> 
> - protected final int subLanesToSwap(AbstractSpecies<?> srcSpecies)
> - protected static <T> VectorShuffle<T> normalizeSubLanesForSpecies(...)
> 
> These methods appear to be implementation helpers for the Big Endian 
> lane/sub-lane normalization path (JDK-8371187/PR #28425) and are not intended 
> to be part of the Vector API surface.
> 
> Since the generated vector classes are in the same jdk.incubator.vector 
> package, "protected" does not seem necessary for access. Making these helpers 
> package-private should keep the implementation access intact while preventing 
> them from appearing as inherited protected API in public Javadoc.
> 
> The PR removes "protected" from these 2 methods, making them package private 
> to keep them out of the public api surface.
> 
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Marked as reviewed by psandoz (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/31034#pullrequestreview-4230158318

Reply via email to