On Thu, 2 Apr 2026 15:52:40 GMT, Aggelos Biboudis <[email protected]> wrote:
> This is the proposed patch for Enhanced Local Variable Declarations (Preview). > > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java line 1195: > 1193: > 1194: // npe logic > 1195: JCIf ifNPEstatement = make.If(makeBinary(Tag.EQ, > letBoundCandidateIdent, makeNull()).setType(syms.booleanType), Why not `attr.makeNullCheck`? Redundant NPE type for Symtab too. test/langtools/tools/javac/patterns/EnhancedVariableDeclStatementTest.java line 2: > 1: /* > 2: * @test /nodynamiccopyright/ Don't think we should do nodynamiccopyright if this doesn't have a golden file output ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30556#discussion_r3031586721 PR Review Comment: https://git.openjdk.org/jdk/pull/30556#discussion_r3031597186
