> Please review this PR which updates the specification of > `ZipOutputStream.setComment(String)` to match the long-standing behavior of > throwing `IllegalArgumentException` when a comment contains characters which > are unmappable using the `Charset` passed in the constructor. > > A new tests is added to reproduce calling setComment with unmappable > characters and verify that it throws IAE. > > PR work revealed that setComment does not explicitly specify behavior if the > comment string is null or an empty string. The method spectifications of > `ZipOutputStream::setComment` and `ZipEntry::setComment` are updated to > clarify the consequences of such string values. > > A CSR has been drafted. Its specification section will be updated after an > initial round of review of the specification text in this PR.
Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision: Explain default charset first, before suggesting alternative constructor ------------- Changes: - all: https://git.openjdk.org/jdk/pull/30338/files - new: https://git.openjdk.org/jdk/pull/30338/files/b74e3c4c..9a38bb5c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=30338&range=11 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30338&range=10-11 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/30338.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/30338/head:pull/30338 PR: https://git.openjdk.org/jdk/pull/30338
