On Fri, 3 Apr 2026 23:23:43 GMT, Sandhya Viswanathan <[email protected]>
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review resolutions
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 7002:
>
>> 7000: vpalignr(dst, xtmp, src1, origin, Assembler::AVX_256bit);
>> 7001: } else {
>> 7002: assert(origin > 16 && origin <= 32, "");
>
> If the slice amount is exactly 32 bytes, the result is simply src2 (no need
> to do vperm2i128 & vpalignr).
> Should this be (origin < 32) ?
Yes VectorSliceNode::Identity routine handled it. Assertion fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24104#discussion_r3043830219
