> Refactor remaining tests in test/jaxp/javax/xml/jaxp/functional to use junit, > along with ancillary utilities and a handful of related tests elsewhere. > > The difficulty in these refactorings is the use of common utilities which > themselves depend on TestNG classes, which are not available when running > JUnit tests. Thus, several bits of functionality in utility classes (esp. > classes in jaxp.library) has had to be re-implemented and inlined. This isn't > terrible, since most of these were one line functions (or complex functions > which could be replaced with one line). > > The only exception to this are the handful of tests using > `compareDocumentWithGold` which is too large to justify inlining. > > > test/jaxp/javax/xml/jaxp/functional/org/xml/sax/ptests/SAXParserNSTableTest.java > test/jaxp/javax/xml/jaxp/functional/test/auctionportal/UserController.java > test/jaxp/javax/xml/jaxp/functional/test/gaptest/Bug4693341.java > > > These tests can be converted at the end when the utility class itself can be > refactored. > > Another complexity is accounting for the differences in test lifecycle > management between TestNG and JUnit. A few classes needed to exploit the > lifecycle and execution modes for single setup and single threaded operation.
David Beaumont has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into jdk_8379798_functional_tests/squashed - Optimize imports and use forward-slash paths - Manual pass to verify assertEquals() parameter order - working snapshot ------------- Changes: - all: https://git.openjdk.org/jdk/pull/30201/files - new: https://git.openjdk.org/jdk/pull/30201/files/bd69d1d3..27c96337 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=30201&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30201&range=01-02 Stats: 16921 lines in 452 files changed: 8760 ins; 3505 del; 4656 mod Patch: https://git.openjdk.org/jdk/pull/30201.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/30201/head:pull/30201 PR: https://git.openjdk.org/jdk/pull/30201
